Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix windows and macOS ci checks #6519

Merged
merged 7 commits into from
Apr 10, 2024
Merged

fix windows and macOS ci checks #6519

merged 7 commits into from
Apr 10, 2024

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Mar 7, 2024

No description provided.

@mgallien mgallien mentioned this pull request Mar 8, 2024
Closed
@mgallien mgallien force-pushed the ci/fixWindowsCi branch 3 times, most recently from 7d8cb24 to 6cb8fd2 Compare March 11, 2024 09:28
claucambra
claucambra reviewed Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good but it seems there are quite a few unrelated changes here, is that intentional?

@mgallien mgallien changed the title switch CI to python 3.12 fix windows and macOS ci checks Apr 10, 2024
mgallien added 6 commits April 10, 2024 17:05
@mgallien
switch CI to python 3.12
df8115d 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
switch Craft cache to proper location
a84c722 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
install inkscape via chocolatey after other dependencies
36aadaa 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
install inkscape using same cache as OpenCppCoverage
49650f2 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
update python for macos and update deployment target
ee28ef8 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
disable coverage on windows due to a crash
cf97b43 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
camilasan
camilasan approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@camilasan camilasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, just use Packager/RepositoryUrl default value.

@mgallien
just use the default value for "Packager/RepositoryUrl"
c588fdc 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6519-c588fdc0491e298b20eef175697d7605c80f87a8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mgallien mgallien merged commit 3a7ae09 into master Apr 10, 2024
10 of 13 checks passed
@mgallien mgallien deleted the ci/fixWindowsCi branch April 10, 2024 21:53
@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra left review comments

@camilasan camilasan camilasan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mgallien @nextcloud-desktop-bot @camilasan @claucambra