Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only display changed network errors during validation of connection #6542

Merged
merged 4 commits into from
Mar 18, 2024
Merged

only display changed network errors during validation of connection #6542

merged 4 commits into from
Mar 18, 2024

Conversation

mgallien
Copy link
Collaborator

No description provided.

@mgallien
Copy link
Collaborator Author

/backport to stable-3.12

@allexzander allexzander self-requested a review March 13, 2024 15:17
allexzander
allexzander suggested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are broken

@allexzander allexzander self-requested a review March 14, 2024 10:42
@mgallien mgallien force-pushed the bugfix/avoidRepeatingTheSameNetworkError branch from ce97508 to 69a0643 Compare March 15, 2024 10:30
mgallien added 4 commits March 18, 2024 09:21
@mgallien
only display changed network errors during validation of connection
6d1f028 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
switch to ubuntu-latest image for CI github actions
e33832f 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
sonarcloud CI check with address sanitizer
8422496 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
update parts of CI to get tests to be OK
2346ec2 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/avoidRepeatingTheSameNetworkError branch from a713a61 to 2346ec2 Compare March 18, 2024 08:21
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6542-2346ec226d96160598f42ce7ee197f4f62d86d9f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
4 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit 3ea60ee into master Mar 18, 2024
10 of 13 checks passed
@mgallien mgallien deleted the bugfix/avoidRepeatingTheSameNetworkError branch March 18, 2024 08:46
@backportbot backportbot bot mentioned this pull request Mar 18, 2024
Merged
3 tasks
@mgallien mgallien mentioned this pull request Mar 18, 2024
Open
@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@claucambra claucambra Awaiting requested review from claucambra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mgallien @nextcloud-desktop-bot @allexzander