Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly compute if a folder is top level or child extern mounted #6578

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

mgallien
Copy link
Collaborator

asks new permission to server to be able to know if a folder is a top level mounted folder

should allow detecting the top level folders from external storages or group folders

shoudl also make the client reliably detect that it is handling a child folder inside a group folder and be allowed to rename such folders

@mgallien mgallien force-pushed the bugfix/allowRenamingFoldersInsideGroupFolders branch from 0aec65c to 6738ff5 Compare March 26, 2024 10:54
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a pair of small nitpicks

src/gui/folderstatusmodel.cpp Outdated Show resolved Hide resolved
src/gui/invalidfilenamedialog.cpp Outdated Show resolved Hide resolved
src/libsync/caseclashconflictsolver.cpp Outdated Show resolved Hide resolved
asks new permission to server to be able to know if a folder is a top
level mounted folder

should allow detecting the top level folders from external storages or
group folders

should also make the client reliably detect that it is handling a child
folder inside a group folder and be allowed to rename such folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/allowRenamingFoldersInsideGroupFolders branch from 6738ff5 to 55034f7 Compare March 27, 2024 13:29
@mgallien mgallien merged commit 6c03f76 into master Mar 27, 2024
9 of 12 checks passed
@mgallien mgallien deleted the bugfix/allowRenamingFoldersInsideGroupFolders branch March 27, 2024 13:29
@mgallien
Copy link
Collaborator Author

/backport to stable-3.12

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6578-55034f7e43a00e07a3c1a51c7c0d83747be9a90c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants