Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error regarding applying of nodiscard to value type #6589

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

claucambra
Copy link
Collaborator

No description provided.

@claucambra claucambra self-assigned this Mar 27, 2024
@claucambra
Copy link
Collaborator Author

/backport to stable-3.12

@claucambra
Copy link
Collaborator Author

/backport to stable-3.13

@claucambra claucambra added this to the 3.13.0 milestone Apr 17, 2024
@camilasan camilasan enabled auto-merge (rebase) April 23, 2024 16:37
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@camilasan camilasan force-pushed the bugfix/false-error-nodiscard-on-value-type branch from b5f851a to eb291f4 Compare April 23, 2024 16:38
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6589-eb291f42183fa525620ee8c7a4958fb8dd1a1b50-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan camilasan disabled auto-merge April 23, 2024 17:10
@camilasan camilasan merged commit 8f6c19e into master Apr 23, 2024
10 of 12 checks passed
@camilasan camilasan deleted the bugfix/false-error-nodiscard-on-value-type branch April 23, 2024 17:10
Copy link

backportbot bot commented Apr 23, 2024

The backport to stable-3.13 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.13
git pull origin stable-3.13

# Create the new backport branch
git checkout -b backport/6589/stable-3.13

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick eb291f42

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6589/stable-3.13

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Apr 23, 2024

The backport to stable-3.12 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.12
git pull origin stable-3.12

# Create the new backport branch
git checkout -b backport/6589/stable-3.12

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick eb291f42

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6589/stable-3.12

Error: Failed to clone repository: Failed to checkout branches: error: Your local changes to the following files would be overwritten by checkout:
src/gui/macOS/ClientCommunicationProtocol.h
Please commit your changes or stash them before you switch branches.
Aborting


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This was referenced Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants