Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always correctly set values for all fields in File Provider sharing UI #6673

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Apr 23, 2024

Closes #6653

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@camilasan camilasan force-pushed the bugfix/file-provider-share-fields branch from a0605cf to b40397d Compare April 23, 2024 16:49
@camilasan camilasan enabled auto-merge (rebase) April 23, 2024 16:49
@camilasan camilasan disabled auto-merge April 23, 2024 17:11
@camilasan camilasan merged commit 92f6de9 into master Apr 23, 2024
9 of 12 checks passed
@camilasan camilasan deleted the bugfix/file-provider-share-fields branch April 23, 2024 17:12
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6673-bf012c2f64d3b2643fd49fe931e30d31cbf2b324-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan
Copy link
Member

/backport to stable-3.13

Copy link

backportbot bot commented Apr 23, 2024

The backport to stable-3.13 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.13
git pull origin stable-3.13

# Create the new backport branch
git checkout -b backport/6673/stable-3.13

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b40397d5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6673/stable-3.13

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Apr 23, 2024

The backport to stable-3.12 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.12
git pull origin stable-3.12

# Create the new backport branch
git checkout -b backport/6673/stable-3.12

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b40397d5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6673/stable-3.12

Error: Failed to clone repository: Failed to checkout branches: error: Your local changes to the following files would be overwritten by checkout:
src/gui/macOS/ClientCommunicationProtocol.h
Please commit your changes or stash them before you switch branches.
Aborting


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mac OS File provider]: note to recepient it is not being displayed in the 'share options' dialog
3 participants