Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix opening of locally available groupfolders in web browser from tray drop-down #6752

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Fix opening of locally available groupfolders in web browser from tray drop-down #6752

merged 4 commits into from
Oct 18, 2024

Conversation

claucambra
Copy link
Collaborator

Caused by bad paths not being found locally -- usually double-slashes. Ensure we parse received group folder paths correctly even if the server makes a mistake

@claucambra claucambra self-assigned this May 15, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
7 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@claucambra claucambra added this to the 3.13.1 milestone Jun 9, 2024
@mgallien mgallien modified the milestones: 3.13.1, 3.13.2 Jul 2, 2024
@camilasan camilasan modified the milestones: 3.13.2, 3.13.3 Jul 9, 2024
@mgallien mgallien modified the milestones: 3.13.3, 3.14.0 Aug 23, 2024
@claucambra claucambra modified the milestones: 3.14.0, 3.14.2 Oct 11, 2024
@claucambra claucambra force-pushed the bugfix/locally-available-folders-open-in-browser-tray-header branch from 280449e to 26b4405 Compare October 16, 2024 02:11
@claucambra
Copy link
Collaborator Author

/backport to stable-3.14

@claucambra claucambra requested a review from camilasan October 16, 2024 02:12
@claucambra claucambra force-pushed the bugfix/locally-available-folders-open-in-browser-tray-header branch 2 times, most recently from e5c571b to 49913e6 Compare October 18, 2024 06:21
@claucambra @mgallien
Constify openLocalFolder
5611f87 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Use for : loop in getFolder
e113118 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Prevent double slashes in group folder path parsing
e2467ba 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Take reference to folder in folder map within User::getFolder
985d2d9 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/locally-available-folders-open-in-browser-tray-header branch from 49913e6 to 985d2d9 Compare October 18, 2024 08:59
@mgallien mgallien merged commit d228d85 into master Oct 18, 2024
9 of 14 checks passed
@mgallien mgallien deleted the bugfix/locally-available-folders-open-in-browser-tray-header branch October 18, 2024 08:59
@backportbot backportbot bot mentioned this pull request Oct 18, 2024
Merged
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6752-985d2d9a7a2071d4d62289d28b10cd7db628bac5-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@allexzander allexzander Awaiting requested review from allexzander

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.14.2
Development

Successfully merging this pull request may close these issues.
4 participants
@claucambra @nextcloud-desktop-bot @mgallien @camilasan