Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "The host name did not match any of the valid hosts for this certificate" notification even when the certificate was valid #6785

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented May 30, 2024

  • I am trying to solve this: the client was complaining about invalid certificates even though the certificate was valid with
    "The host name did not match any of the valid hosts for this certificate"
  • I only could reproduce what was reported with stable-3.13 and Qt 5 on Linux.
  • We might have hit a Qt5 bug, but I couldn't find reports.
  • The issue was gone once the setting of ssl options were removed in 5299677.

@camilasan camilasan requested review from mgallien and claucambra May 30, 2024 15:35
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my inline comments

src/libsync/networkjobs.cpp Outdated Show resolved Hide resolved
src/gui/accountsetupfromcommandlinejob.cpp Outdated Show resolved Hide resolved
src/gui/owncloudsetupwizard.cpp Outdated Show resolved Hide resolved
@camilasan camilasan force-pushed the bugfix/qt5/certificates branch 2 times, most recently from 1f47254 to 2f57d7e Compare June 5, 2024 19:41
@camilasan camilasan force-pushed the bugfix/qt5/certificates branch from 2f57d7e to b8a5954 Compare June 23, 2024 14:54
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build is broken
can you make sure CI is green ?

@camilasan camilasan force-pushed the bugfix/qt5/certificates branch 2 times, most recently from e23f2cd to 592ef1c Compare June 24, 2024 10:07
camilasan added 5 commits July 1, 2024 16:35
…nections.

One option is said to be possibly breaking some sites: QSsl::SslOptionDisableSessionTickets
It disables the SSL session ticket extension and some servers are not compatible with the extension.

Signed-off-by: Camila Ayres <hello@camilasan.com>
…s are allowed.

Signed-off-by: Camila Ayres <hello@camilasan.com>
- Those settings were removed.
- Modernize CheckServerJob::finished.

Signed-off-by: Camila Ayres <hello@camilasan.com>
We have set QNetworkRequest::RedirectPolicyAttribute to QNetworkRequest::NoLessSafeRedirectPolicy:
the Network Access API should automatically follow a HTTP redirect response.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
@mgallien mgallien force-pushed the bugfix/qt5/certificates branch from 592ef1c to f1e3901 Compare July 1, 2024 14:35
@mgallien mgallien enabled auto-merge July 1, 2024 14:35
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6785-f1e3901ea324f7cc4fd95de4dad0df1f9ff5a3f5-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Jul 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit fdd5356 into stable-3.13 Jul 1, 2024
10 of 13 checks passed
@mgallien mgallien deleted the bugfix/qt5/certificates branch July 1, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants