Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.13] Bugfix nextcloudcmd when syncing results in deleting all files #6857

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 28, 2024

Backport of PR #6773

@backportbot backportbot bot requested review from mgallien and camilasan June 28, 2024 16:19
@backportbot backportbot bot added this to the 3.13.1 milestone Jun 28, 2024
…ing signal to display warning.

The signal is not connected to any slot when running nextcloudcmd.
The callback to finish the sync was never being called because the check for the config was done in the slot,
which was never called.

Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
Signed-off-by: Camila Ayres <hello@camilasan.com>
@mgallien mgallien force-pushed the backport/6773/stable-3.13 branch from 1e93c64 to 25c7a73 Compare June 28, 2024 16:33
@mgallien mgallien merged commit 17fcf14 into stable-3.13 Jun 28, 2024
1 of 2 checks passed
@mgallien mgallien deleted the backport/6773/stable-3.13 branch June 28, 2024 16:35
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6857-25c7a737228c91c9fb5a1bbacb081daa6d783cf2-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Jun 28, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants