Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.12] avoid deadlock: cancel hydration requests coming from itself #6870

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Jul 1, 2024

Backport of PR #6868

our current infrastructure will cause a deadlock for any hydration
requests coming from desktop files client itself

the main thread is responsible for executing the hydration request but
if the same thread is already blocked waiting for the hydration to
happen, both (open system call and hydration request handling) process
will never be completed and wait for each over in a stuck cycle

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien requested review from camilasan and claucambra July 1, 2024 14:25
@mgallien mgallien added this to the 3.12.7 milestone Jul 1, 2024
@mgallien mgallien merged commit e9ec396 into stable-3.12 Jul 1, 2024
9 of 12 checks passed
@mgallien mgallien deleted the backport/6868/stable-3.12 branch July 1, 2024 14:26
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6870-ac5e6c7f39465425c10912ec052fc694b40af24d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Jul 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants