-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Narrow down ReadWrite folder permission to owner #6949
Narrow down ReadWrite folder permission to owner #6949
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After further feedback it seems this code has deeper issues
We are investigating a broader rewrite of this right now
Thank you for your contribution, though -- we definitely have issues properly handling reassigning the correct permissions
@claucambra I am not sure I would want to skip this change |
Aren't these the same permissions we applied prior to the last patch, though? Those were causing even more issues |
Signed-off-by: suiso67 <suiso67@macadamia.rocks>
1b65073
to
a270756
Compare
I did rebase and force-pushed this branch, but it seems like there're other issues which I don't have context of. Can you give me issue/pr links related to this? |
This PR does not seem to solve this use case: #6863 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suiso67 Upon discussion and a rethink I think we can merge this in the mean time, as setting all perms is not a viable solution and we need a better way to handle setting/restoring perms
@suiso67 could you rebase once more? |
/backport to stable-3.13 |
/backport to stable-3.14 |
Sorry for being late, it has been merged already. If you don't mind, I'd like to know if there're more context about related issue you're talking about. I came here completely blind and kind of just reverted the change, and I'd like to contribute to the real issue even thought I can't guarantee anything. |
#6839 seem to add
group_write
andothers_write
along withowner_write
permission when settingFileSystem::FolderPermissions::ReadWrite
permission to a folder, which is addressed in #6863. Please let me know if I'm missing any context.Resolves #6863