Feature/server forbidden filenames

[claucambra]

[tobiasKaminsky]

From my limited c++ understanding, this means that you exclude those wrong files/folders from sync?
But we need to have an notification entry

• stating that this file/folder is not allowed
• with a valid error message
• with an option to rename

[claucambra]

From my limited c++ understanding, this means that you exclude those wrong files/folders from sync? But we need to have an notification entry

• stating that this file/folder is not allowed
• with a valid error message
• with an option to rename

We already have existing handling for this from other implementations of file blacklisting on the server. CSYNC_FILE_EXCLUDE_SERVER_BLACKLISTED exclusion types lead to: item->_errorString = tr("The filename is blacklisted on the server."); slightly further down this method

The result is a warning activity in the tray

[tobiasKaminsky]

The result is a warning activity in the tray

If those capabilities are enabled, I think this should be an error, instead of a warning.
What do you think? :)

[claucambra]

The result is a warning activity in the tray

If those capabilities are enabled, I think this should be an error, instead of a warning. What do you think? :)

I don't have an issue with it, @mgallien would this have any ramifications?

[mgallien]

The result is a warning activity in the tray

If those capabilities are enabled, I think this should be an error, instead of a warning. What do you think? :)

I don't have an issue with it, @mgallien would this have any ramifications?

@claucambra I am testing this PR
having had a look at the changes, I fear that will be unusable by an user
how can they fix the warnings that this will generate for them ?
will they get an easily reachable way to rename and/or delete the unwanted files or folders ?

[mgallien]

@tobiasKaminsky @claucambra
I did test with 4 files having a forbidden file extension
I get this

if I click on the first line (the warning activity), nothing happen
are we sure we want to merge the current state ?

[claucambra]

The result is a warning activity in the tray

If those capabilities are enabled, I think this should be an error, instead of a warning. What do you think? :)

I don't have an issue with it, @mgallien would this have any ramifications?

@claucambra I am testing this PR having had a look at the changes, I fear that will be unusable by an user how can they fix the warnings that this will generate for them ? will they get an easily reachable way to rename and/or delete the unwanted files or folders ?

I will add a rename button to these activities, this way the warnings are actionable for the users

[tobiasKaminsky]

This is way better.
Can you also add the specific error message by server, not the generic "file is blacklisted"?
And add a "rename" button, otherwise no one knows that they need to click on it to start rename dialog.

Same for the dialog: there we should also show the correct error message, as this is misleading right now:

--> com1 is a reserved filename.

[tobiasKaminsky]

Rename button looks good ✔
Correct error message, and message in dialog pending : )

[claucambra]

Okay, will go ahead and modify the texts

[tobiasKaminsky]

Okay, will go ahead and modify the texts

they need to be dynamic from server

[claucambra]

Okay, will go ahead and modify the texts

they need to be dynamic from server

@tobiasKaminsky @mgallien This is the current state:

The messages are dynamic depending on the forbidden characters and the reason(s) for the upload failure

[sonarcloud]

Quality Gate failed

Failed conditions
2 Security Hotspots
50.6% Coverage on New Code (required ≥ 80%)
44 New Code Smells (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-6965-abb1f89119bd25e887cf8a8b769423c07d0fbf95-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.