Make sure we do not renotify notifications when we have received the same etag as during the last check #6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mgallien
approved these changes
Sep 12, 2024
|
/backport to stable-3.14 |
…same etag as during the last check Do this regardless of what the server's response is Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
This prevents situations where the server does not provide an etag header. This would make the empty pre-fetch and empty post-fetch etag headers match, meaning notifications would never be notified Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
mgallien
force-pushed
the
bugfix/prevent-renotification
branch
from
9941315 to
6b0e485
Compare
|
AppImage file: nextcloud-PR-6970-6b0e485ab9b3b9f2a25bda325144cfaa7e0ff67a-x86_64.AppImage |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this regardless of what the server's response is