Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.13] Bugfix/hide encrypt from context menu #7018

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 22, 2024

Backport of #7016

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from claucambra and mgallien August 22, 2024 08:13
@backportbot backportbot bot added this to the 3.13.3 milestone Aug 22, 2024
fix string data being invalid when using QStringView

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
with current end-to-end encryption only top folders can be encrypted

limit the availability of the menu entry to top folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
in the contextual menu shown in files explorer will show encrypt menu

entry only for top folders that are non-encrypted and empty

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the backport/7016/stable-3.13 branch from db7deb1 to 07cd52b Compare August 22, 2024 09:04
@mgallien mgallien marked this pull request as ready for review August 22, 2024 09:04
@mgallien mgallien enabled auto-merge August 22, 2024 09:04
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7018-07cd52bb237f1f68437a95e37733946972d9f2a0-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Aug 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@mgallien mgallien merged commit 9322c11 into stable-3.13 Aug 22, 2024
11 of 14 checks passed
@mgallien mgallien deleted the backport/7016/stable-3.13 branch August 22, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants