Add some extra syncing details to the tray icon tooltip

[nilsding]

This pull request adds some more details to the tray icon tooltip text.

There was some unused code that updated some status bar text, so I opted to re-use that. As of now it displays what the old code did -- the file size to be synced and the estimated time left if applicable.

On my Linux (KDE) system it will display that information per folder:

On Windows it will only display if there is only one folder to be synced. The tooltip message will roughly look like that (still need to check that it doesn't get truncated):

[camilasan]

adding @nextcloud/designers for feedback.

[jancborchardt]

@nilsding thanks for your contribution! :) Small piece of feedback:
I assume the first "Nextcloud" in the text refers to the app name, and the second to the folder name? Considering that this is the default and it makes the text a bit complex, we could leave the first "Nextcloud: Folder" part out? So basically show it like in your Windows example, only referring to the folder name directly:

Nextcloud: Syncing 19 MB (3 minutes left)

Where "Nextcloud" is the folder name.

[nilsding]

Hey @jancborchardt, thanks for the feedback :D

Getting rid of the Nextcloud: application name prefix would be as easy as modifying/removing the overridden method in systray.cpp.

desktop/src/gui/systray.cpp

Lines 569 to 572 in 99aa255

	void Systray::setToolTip(const QString &tip)
	{
	QSystemTrayIcon::setToolTip(tr("%1: %2").arg(Theme::instance()->appNameGUI(), tip));
	}

I think we could keep it for the Windows platform though, as it will display a summary of everything anyway.

On other platforms the tooltip can be more even more detailed, e.g. display the sync status of all possible folder sync configurations (and on macOS even the accounts using the VFS), e.g.

I think in the case of more than one active sync configuration it'd be better to display the Folder prefix too, just to be extra clear. And if there's only one sync configuration, that prefix can be dropped entirely. What do you think? :)

[jancborchardt]

I think in the case of more than one active sync configuration it'd be better to display the Folder prefix too, just to be extra clear. And if there's only one sync configuration, that prefix can be dropped entirely. What do you think? :)

I would say the "Folder" prefix is not needed in either case, as people set up the connections. But I'm fine either way. :)

[nilsding]

rebased and updated. Now it looks more clean:

...whereas on Windows it segfaults on with more than one connection. Will fix that shortly.

[nilsding]

this is what the tooltip will look like on Windows with multiple sync connections now:

With only one connection it will be still the same as before:

I'll squash that fixup commit into the first one when this PR gets some approvals. :>

[jancborchardt]

@nilsding looks great now! Only a super small detail, we can shorten the time display from "3 minutes 15 seconds remaining" to "3:15 minutes remaining"
Then it also usually doesn't line break.

But it's also fine to do it in a follow-up if it just uses some desktop native time format.

[nilsding]

Sadly there is no utility function to convert the time in milliseconds to a short time like 3:15 yet, but I think for the tooltip it's more than enough to say 3 minutes instead:

I also added some handling for the special case when the estimated ETA is 0; i.e. instead of 0 seconds left it will now display A few seconds left, similar to how the usual folder status view does it.

[mgallien]

thanks 😄
please have a look at my inline comments

[nilsding]

@mgallien thanks for the review :)

re. the app name prefix on Windows I'm waiting on Jan's opinion first -- if neither of us have a strong opinion about that I'll just drop that override altogether

[camilasan]

re. the app name prefix on Windows I'm waiting on Jan's opinion first -- if neither of us have a strong opinion about that I'll just drop that override altogether

I would just drop it, we usually try to keep the same between the 3 platforms unless there is specific guidelines saying otherwise.

[nilsding]

we usually try to keep the same between the 3 platforms unless there is specific guidelines saying otherwise.

ah, good to know. Will remove it then :>

[nilsding]

just cleaned up the commits a bit and rebased on top of master again

[mgallien]

@nilsding thanks again 😄
I will take care of the merge as PR from external repositories (i.e. clone) will not be run at our drone CI
sonarcloud check will also fail due to access rights again

[mgallien]

/backport to stable-3.14