Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count the files deletion and warn if threshold is exceeded #7116

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

mgallien
Copy link
Collaborator

No description provided.

@mgallien mgallien force-pushed the feature/warnOfManyDeleteInstructions branch 3 times, most recently from 23b8a65 to 1194b74 Compare September 17, 2024 14:33
@mgallien mgallien force-pushed the feature/warnOfManyDeleteInstructions branch from 1194b74 to 5567654 Compare September 18, 2024 09:51
@mgallien
Copy link
Collaborator Author

still missing proper automated tests
will work on them before merge

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the feature/warnOfManyDeleteInstructions branch from 5567654 to d31b3b0 Compare September 30, 2024 12:33
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7116-d31b3b068fa7ee2d7b8d1f58b5714991da14559f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
Copy link
Collaborator Author

/backport to stable-3.12

Copy link

sonarcloud bot commented Sep 30, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Bugs (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)
42 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit 7c546ba into master Sep 30, 2024
12 of 15 checks passed
@mgallien mgallien deleted the feature/warnOfManyDeleteInstructions branch September 30, 2024 14:42
@mgallien
Copy link
Collaborator Author

/backport to stable-3.13

@mgallien
Copy link
Collaborator Author

/backport to stable-3.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants