Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.12] Bugfix/fix vfs folder state when remote move is forbidden #7133

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

mgallien
Copy link
Collaborator

Backport of PR #6717

when remote move is forbidden, desktop client will move back the folder
to its original name

in such cases, we were forgetting to set VFS metadata in their proper
state (i.e. placeholder in sync)

so ensure that when a remote move fails, we still touch VFS metadata
when appropriate and handle errors

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
when doing local discovery, it is possible that files or folders may be
discovered with VFS metadata not up to date (i.e. placeholder file not
set in sync)

in such case, generate a propagation instruction to set them in sync

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien requested a review from claucambra September 16, 2024 15:34
@mgallien mgallien changed the base branch from master to stable-3.12 September 16, 2024 15:34
@mgallien mgallien merged commit 836f999 into stable-3.12 Sep 16, 2024
1 of 2 checks passed
@mgallien mgallien deleted the backport/6717/stable-3.12 branch September 16, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant