Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing default chunk size to 100MB #7161

Merged
merged 1 commit into from
Sep 26, 2024
Merged

changing default chunk size to 100MB #7161

merged 1 commit into from
Sep 26, 2024

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Sep 19, 2024 •
edited
Loading

goal is to have better performance and uniform behavior between all files clients

@mgallien mgallien force-pushed the bugfix/changeDefaultChunkSize branch from 1886427 to faa6fe4 Compare September 19, 2024 10:26
provokateurin
provokateurin requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use correct notation and size, we use that internally in server as well.

src/libsync/configfile.cpp Outdated Show resolved Hide resolved
src/libsync/syncoptions.h Outdated Show resolved Hide resolved
@mgallien mgallien force-pushed the bugfix/changeDefaultChunkSize branch from faa6fe4 to 5b0146a Compare September 24, 2024 08:55
@provokateurin
Copy link
Member

nextcloud/server#47682 just linking for reference :)

@mgallien mgallien force-pushed the bugfix/changeDefaultChunkSize branch from 5b0146a to 71d1742 Compare September 24, 2024 12:52
@mgallien mgallien force-pushed the bugfix/changeDefaultChunkSize branch 2 times, most recently from 1e2a17c to 87b50e4 Compare September 25, 2024 16:22
@mgallien mgallien enabled auto-merge September 25, 2024 16:23
@mgallien
changing default chunk size to 100MB
570749c 
goal is to have better performance and uniform behavior between all files clients

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/changeDefaultChunkSize branch from 87b50e4 to 570749c Compare September 26, 2024 08:56
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7161-570749c89e3ab4439c01dedfd86b30333cd1f245-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
18 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit c44d29d into master Sep 26, 2024
11 of 15 checks passed
@mgallien mgallien deleted the bugfix/changeDefaultChunkSize branch September 26, 2024 09:52
@szaimen szaimen mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@provokateurin provokateurin provokateurin approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgallien @provokateurin @nextcloud-desktop-bot @claucambra