Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/missing unlock command #7208

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Bugfix/missing unlock command #7208

merged 2 commits into from
Sep 26, 2024

Conversation

mgallien
Copy link
Collaborator

No description provided.

@mgallien mgallien force-pushed the bugfix/missingUnlockCommand branch from 8758593 to b3cdc17 Compare September 25, 2024 15:24
@mgallien
Copy link
Collaborator Author

/backport to stable-3.14

@mgallien
Copy link
Collaborator Author

/backport to stable-3.13

@mgallien
Copy link
Collaborator Author

/backport to stable-3.12

@mgallien mgallien force-pushed the bugfix/missingUnlockCommand branch from b3cdc17 to c35dc68 Compare September 26, 2024 07:24
a file can be unlocked when:

 * the lock is an user lock from the current user
 * the lock is a token lock from the current desktop files client

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
to be able to modify a locked file using token lock, we must sent it
with webdav requests

this must not be sent if the file is locked but the lock type is not a
token lock

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/missingUnlockCommand branch from c35dc68 to c775620 Compare September 26, 2024 07:25
@mgallien mgallien requested a review from camilasan September 26, 2024 07:26
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7208-c77562022d05d3b3755e2155e62497e3f7b07c06-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Sep 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23 New Code Smells (required ≤ 0)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit 42c89bd into master Sep 26, 2024
11 of 15 checks passed
@mgallien mgallien deleted the bugfix/missingUnlockCommand branch September 26, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants