Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.12] create a permanent log of delete actions #7250

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 1, 2024

Backport of #7028

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from claucambra and mgallien October 1, 2024 14:40
@backportbot backportbot bot added this to the 3.12.8 milestone Oct 1, 2024
will log all deletions with the result of the discovery by the sync
enginre

should enable analyze even long time after such a delete occured

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the backport/7028/stable-3.12 branch from 9d8f5ec to a8a3c0f Compare October 1, 2024 14:55
@mgallien mgallien marked this pull request as ready for review October 1, 2024 14:57
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.5% Coverage on New Code (required ≥ 80%)
5 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit 1dea4dc into stable-3.12 Oct 1, 2024
10 of 14 checks passed
@mgallien mgallien deleted the backport/7028/stable-3.12 branch October 1, 2024 16:00
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7250-a8a3c0fb32b4d1474be8bb985c4272193648df46-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants