Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme/Language #7288

Closed
wants to merge 5 commits into from
Closed

Theme/Language #7288

wants to merge 5 commits into from

Conversation

wfxey
Copy link

@wfxey wfxey commented Oct 9, 2024

I changed the langauge file for German and changed the design a bit.
See changelog for more infos.

@wfxey
Theme/Language
1e752ba 
I changed the langauge file for German and changed the design a bit.

Signed-off-by: wfxey <158351052+wfxey@users.noreply.github.com>
@wfxey wfxey marked this pull request as draft October 9, 2024 18:40
@wfxey wfxey marked this pull request as ready for review October 9, 2024 18:40
wfxey
wfxey commented Oct 9, 2024
View reviewed changes
Copy link
Author

@wfxey wfxey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delteted .git... files by mistake

@wfxey wfxey closed this Oct 9, 2024
@wfxey wfxey reopened this Oct 9, 2024
@wfxey wfxey marked this pull request as draft October 9, 2024 18:43
wfxey added 4 commits October 9, 2024 20:45
@wfxey
Create .gitattributes
e0d4f91 
Signed-off-by: wfxey <158351052+wfxey@users.noreply.github.com>
@wfxey
Create .gitignore
0522932 
Signed-off-by: wfxey <158351052+wfxey@users.noreply.github.com>
@wfxey
Update .tag
6aceccc 
Signed-off-by: wfxey <158351052+wfxey@users.noreply.github.com>
@wfxey
Create .gitignore
0d82bb6 
Signed-off-by: wfxey <158351052+wfxey@users.noreply.github.com>
@wfxey wfxey marked this pull request as ready for review October 9, 2024 18:48
claucambra
claucambra requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, a couple of things:

  1. Translation files should be changed via our translation system at Transifex, not directly via the files
  2. What is the reasoning behind the style changes? What are the efects of your changes? (could you provide screenshots?)
  3. You have deleted some .gitignore files without a clear reason, could you explain why?

@wfxey
Copy link
Author

wfxey commented Oct 10, 2024

Hello, a couple of things:

  1. Translation files should be changed via our translation system at Transifex, not directly via the files
  2. What is the reasoning behind the style changes? What are the efects of your changes? (could you provide screenshots?)
  3. You have deleted some .gitignore files without a clear reason, could you explain why?
  1. I didn't knew it sorry
  2. On Windows in Dark Mode you cant see the difference between the color of the text and the background of the button.
  3. I added them again, my bad that I deleted them. It was automatic by GitHub Dektop

@camilasan
Copy link
Member

camilasan commented Oct 10, 2024 •
edited
Loading

  • I didn't knew it sorry

don't worry, thanks for trying <3
This is what we use for translation: https://app.transifex.com/nextcloud/nextcloud/translate/#de/client/328739356

  • On Windows in Dark Mode you cant see the difference between the color of the text and the background of the button.

We have a workaround for this by using another theme on Windows: #7270
It is actually bug in Qt 6.
The fix will be in 3.14.2 (next week or so).

@wfxey
Copy link
Author

wfxey commented Oct 12, 2024

  • I didn't knew it sorry

don't worry, thanks for trying <3 This is what we use for translation: https://app.transifex.com/nextcloud/nextcloud/translate/#de/client/328739356

  • On Windows in Dark Mode you cant see the difference between the color of the text and the background of the button.

We have a workaround for this by using another theme on Windows: #7270 It is actually bug in Qt 6. The fix will be in 3.14.2 (next week or so).

Oh okay nicee

@wfxey
Copy link
Author

wfxey commented Oct 12, 2024

I will try the Website

@wfxey wfxey closed this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wfxey @camilasan @claucambra