Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning logs #7290

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Cleaning logs #7290

merged 3 commits into from
Oct 10, 2024

Conversation

mgallien
Copy link
Collaborator

making logs more useful using logs collected from complex situations
trying to make them less verbose and more targeted toward useful information (i.e. being able to understand sync issues)

@mgallien
remove not so usefull log output
d4f28b2 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
remove info level output from activity list model: not so usefull
3835d37 
they just are printed when everything is working fine

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
improve log when too many deleted files are detected
6c5c7c2 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/improveLogsAgainFromUsingThem branch from 6314abe to 6c5c7c2 Compare October 10, 2024 12:36
@mgallien mgallien enabled auto-merge October 10, 2024 12:37
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7290-6c5c7c27d2a0e69bbf7a7d20b4ef2f00dee7ab78-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
51 New Code Smells (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
1 New Bugs (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit ceaa125 into master Oct 10, 2024
11 of 15 checks passed
@mgallien mgallien deleted the bugfix/improveLogsAgainFromUsingThem branch October 10, 2024 13:08
@mgallien
Copy link
Collaborator Author

/backport to stable-3.12

@mgallien
Copy link
Collaborator Author

/backport to stable-3.13

@mgallien
Copy link
Collaborator Author

/backport to stable-3.14

This was referenced Oct 10, 2024
Merged
Merged
@backportbot backportbot bot mentioned this pull request Oct 10, 2024
Merged
2 tasks
@mgallien
Copy link
Collaborator Author

/backport 6c5c7c2 to stable-3.13

@mgallien
Copy link
Collaborator Author

/backport 6c5c7c2 to stable-3.14

@backportbot backportbot bot mentioned this pull request Oct 11, 2024
Merged
1 task
@backportbot backportbot bot mentioned this pull request Oct 11, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgallien @nextcloud-desktop-bot @claucambra