Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on receiving reply of a remote MOVE: always record it #7351

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mgallien
Copy link
Collaborator

even if local item has disappeared, record the result of a remote MOVE when receiving the reply

enable better state tracking when syncing rename or move operations

@mgallien mgallien added this to the 3.14.2 milestone Oct 17, 2024
@mgallien
Copy link
Collaborator Author

/backport to stable-3.12

@mgallien
Copy link
Collaborator Author

/backport to stable-3.13

@mgallien
Copy link
Collaborator Author

/backport to stable-3.14

@mgallien mgallien force-pushed the bugfix/alwaysRecordMovedItemsAfterServerReplied branch 2 times, most recently from 87517e5 to 130431e Compare October 17, 2024 21:22
even if local item has disappeared, record the result of a remote MOVE
when receiving the reply

enable better state tracking when syncing rename or move operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/alwaysRecordMovedItemsAfterServerReplied branch from 130431e to 0eb5ddd Compare October 18, 2024 02:09
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7351-0eb5ddd44252c8c6f866b5de95d01ee36d62ca5d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 2d30024 into master Oct 18, 2024
9 of 14 checks passed
@claucambra claucambra deleted the bugfix/alwaysRecordMovedItemsAfterServerReplied branch October 18, 2024 02:22
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
30 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants