Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show received share information in share view #7373

Merged
merged 20 commits into from
Nov 22, 2024
Merged

Show received share information in share view #7373

merged 20 commits into from
Nov 22, 2024

Conversation

claucambra
Copy link
Collaborator

Screenshot 2024-10-21 at 02 09 40

Closes #3096

@claucambra claucambra added the feature: 👥 sharing Sharing dialog and functionalities. label Oct 20, 2024
@claucambra claucambra added this to the 3.15.0 milestone Oct 20, 2024
@claucambra claucambra self-assigned this Oct 20, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
18.8% Coverage on New Code (required ≥ 80%)
39 New Code Smells (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

mgallien
mgallien requested changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments
especially the one about use of AvatarJob class

@claucambra claucambra requested a review from mgallien November 20, 2024 07:02
@claucambra
Add displayFileOwner property to ShareModel
f0533a5 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add fileOwnerDisplayName property to ShareModel
2e765c6 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Set if the file owner should be displayed and the file owner display …
117e2cf 
…name on propfind in sharemodel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add sharedWithMe-related properties to sharemodel
e0d3fc5 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Also fetch shared with me share on target path
4dcf545 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
When handling fetched shares, record shared-with-me related informati…
4a1fa92 
…on in sharemodel properties

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Display file owner information (if not self) in share view
cfc4c26 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Display shared with me file's share expiry in share view if relevant
6620bf2 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Display share owner rather than file owner (this is more relevant to …
b325686 
…user)

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Bolden string showing who owns the share that was shared with me
1645912 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Convert ImageProvider in an async image provider using an internal im…
c38a510 
…age response

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add ability to fetch remote server avatars in usermodel avatar ImageR…
bc74c5a 
…esponse

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Add shareOwnerAvatar property to ShareModel
380fe4a 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Build shareOwnerAvatar image provider string when handling sharedWith…
97ae48e 
…Me share in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Display image for sharedWithMe share owner in share view
f0e88c7 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Ensure requestedSize for avatars is valid
3957a30 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Ensure account pointer is valid when fetching avatars
aa60f44 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Clean up whitespace in ShareModel::slotPropfindReceived
0c32d78 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Match definition of shared_with_me with other properties in OcsShareJ…
a8b0f23 
…ob getShares

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra
Ensure avatarJob is run on the respective account's QNAM thread
8baf105 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the feature/display-sharedwithme-info branch from 13141db to 8baf105 Compare November 22, 2024 08:33
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7373-8baf1052706bf89d1de1d893673ce52a3a67320a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 16a2f0d into master Nov 22, 2024
10 of 14 checks passed
@mgallien mgallien deleted the feature/display-sharedwithme-info branch November 22, 2024 08:46
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
17.2% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)
39 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
feature: 👥 sharing Sharing dialog and functionalities.
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.

Show expiration date on receiving shares
3 participants
@claucambra @nextcloud-desktop-bot @mgallien