Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding used for override server url #7407

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

claucambra
Copy link
Collaborator

Fixes issues when displaying names of multiple override server urls (e.g. those that contain umlauts)

@claucambra claucambra added the bug label Oct 24, 2024
@claucambra claucambra self-assigned this Oct 24, 2024
@claucambra claucambra added this to the 3.14.3 milestone Oct 24, 2024
@claucambra
Copy link
Collaborator Author

/backport to stable-3.14

@claucambra claucambra modified the milestones: 3.14.4, 3.14.5 Nov 3, 2024
@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/encoding-override-server-url branch from 1b408c3 to 96e2264 Compare November 19, 2024 12:40
@mgallien mgallien merged commit 3c707ac into master Nov 19, 2024
9 of 13 checks passed
@mgallien mgallien deleted the bugfix/encoding-override-server-url branch November 19, 2024 12:40
Copy link

backportbot bot commented Nov 19, 2024

The backport to stable-3.14 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.14
git pull origin stable-3.14

# Create the new backport branch
git checkout -b backport/7407/stable-3.14

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 96e2264b

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/7407/stable-3.14

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7407-96e2264baaa359e60b5d5161eaedcc7faf76c1a7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants