Improve read only virtual files support on Windows #7477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
force-pushed
the
bugfix/readOnlyVirtualFilesFixes
branch
from
45284a6 to
a77f1b1
Compare
8 tasks
mgallien
force-pushed
the
bugfix/readOnlyVirtualFilesFixes
branch
2 times, most recently
from
45faa94 to
c5d66c9
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
claucambra
requested changes
Nov 22, 2024
There was a problem hiding this comment.
@mgallien I think the commit history is messed up, there are some dark mode relate d changes here
ensure that even if move to trash is enabled, we do not erroneously try to move online only files or folders to trash bin Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we need to make shortcut files be proper virtual placeholder files let the sync engine use the proper item type for that Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we cannot do a single call to convert the plain old file to be a dehydrated virtual file placeholder split the conversion into a separate initial API call fix transition from releases < 3.14 to current releases that have first class support for windows shortcuts (so called link files) Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
should make the existing log more useful when tracking the self requested implicit hydration bugs Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
we were using specialized API to set the file permissions on the windows shortcut and later falling back to the generic code path due to the mising return Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
will prevent some type of activity being added to the list from triggering implicit hydration during synchronization most probably breaks existing open actions on those activities Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
change the way we evaluate a folder permissions to be read-only when no new file or new folders can be created if those permissions are lacking, client will make the local folder read-only if those permissions are granted, client will make local folder read-write Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
mgallien
force-pushed
the
bugfix/readOnlyVirtualFilesFixes
branch
from
c5d66c9 to
85e71d4
Compare
claucambra
approved these changes
Nov 22, 2024
|
AppImage file: nextcloud-PR-7477-85e71d47bfa64c3293afc2b88eff7e72dbfce3c3-x86_64.AppImage |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.