Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Fix deprecation warnings when building with Qt 6.8.0 #7584

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

all: Fix deprecation warnings when building with Qt 6.8.0 #7584

wants to merge 22 commits into from

Conversation

claucambra
Copy link
Collaborator

No description provided.

@claucambra claucambra self-assigned this Nov 28, 2024
@claucambra claucambra added this to the 3.16.0 milestone Nov 28, 2024
@mgallien mgallien force-pushed the bugfix/qt-6-8-compat branch from f639063 to 2835d18 Compare December 3, 2024 18:02
@claucambra claucambra force-pushed the bugfix/qt-6-8-compat branch 2 times, most recently from e1a20fa to cedb807 Compare December 5, 2024 07:14
@mgallien mgallien force-pushed the bugfix/qt-6-8-compat branch 2 times, most recently from 18e49b2 to c4d52b9 Compare December 11, 2024 10:07
claucambra and others added 21 commits December 13, 2024 17:04
@claucambra @mgallien
Replace all uses of qAsConst with std::as_const
0b76e35 
Fixes deprecation warnings on Qt 6.8.0

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Ensure use of QMessageBox-using QMessageBox::critical
24933eb 
Fixes deprecation warnings

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f ensure qmessagebox

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f2 ensure qm

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f3

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f4

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Replace use of deprecated QLibraryInfo::location with QLibraryInfo::path
d978b1f 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Replace use of itemDelegate with itemDelegateForIndex
58971d5 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Replace use of QCheckBox::stateChanged with QCheckBox::checkStateChanged
ec1ac85 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Use QTimeZone::UTC instead of Qt::UTC
9d86dbb 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f qtimezone

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Remove unneeded take from systray
313a8a3 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Do not use const char * to add data to crypto hash
bacdf99 
method is deprecated

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

fix qbyte

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Replace deprecated QVariant types with QMetaType
2a2a816 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use QVariant metaType instead of type

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f metatype

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Use char16_t cast instead of ushort cast
dabe041 
Fix deprecation warning

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Use unique_ptr over scoped pointer
25ac0b6 
take is deprecated in scoped pointer

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f handle

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use unique_ptr instead of scoped pointer for propagator firstJob

Fixes deprecation warning

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use unique_ptr for discoveryphase, replace take with release

Fix deprecation warn

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f unique

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Use matchView instead of match
6fc2d3b 
match is deprecated

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Use std::prev ove -1ing the iterator
72e7825 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use std::prev for it rather than -1 in Syncengine

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Replace QWebSocket::error with errorOccurred
0f11964 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Use QDomDocument content method returning ParseResult
04842ba 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use ParseResult returning QDomDocument setContent

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f parseresult

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Move pinned Qt and Craft cache versions to 6.8.0 and 24.12 respectively
445352b 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Use default downloaddir for craft
34c12bc 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien
use CI images with Qt 6.8.0
f07b120 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@claucambra @mgallien
Replace aAsConst with std::as_const in tests
b118b80 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Use non-deprecated qChecksum in qtlocalpeer of qtsingleapplication
3356d77 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Use QTimeZone in startOfDay for QDate in tests
beeca9a 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra @mgallien
Use std::next rather than adding to iterator in tests
92eb18a 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@mgallien mgallien force-pushed the bugfix/qt-6-8-compat branch from c4d52b9 to 92eb18a Compare December 13, 2024 16:04
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7584-92eb18a9406106c369b4d92807289d1e7d4e6391-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots
45.9% Coverage on New Code (required ≥ 80%)
1 New Bugs (required ≤ 0)
D Security Rating on New Code (required ≥ A)
370 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

At least 1 approving review is required to merge this pull request.

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@claucambra @nextcloud-desktop-bot @mgallien