Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: correctly detects network drive. #7636

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Fix: correctly detects network drive. #7636

merged 7 commits into from
Dec 12, 2024

Conversation

camilasan
Copy link
Member

No description provided.

@camilasan camilasan added this to the 3.15.1 milestone Dec 10, 2024
@camilasan
Copy link
Member Author

/backport to stable-3.15

@camilasan camilasan mentioned this pull request Dec 10, 2024
Open
mgallien
mgallien requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems the automated tests are failing
can you have a look @camilasan

@camilasan camilasan force-pushed the bugfix/vfs-folder-detection branch 4 times, most recently from 2c64e88 to 7b9d4aa Compare December 11, 2024 14:58
mgallien
mgallien requested changes Dec 12, 2024
View reviewed changes
src/gui/folderwizard.cpp Outdated Show resolved Hide resolved
src/gui/folderman.h Outdated Show resolved Hide resolved
src/gui/folderman.h Outdated Show resolved Hide resolved
@camilasan camilasan force-pushed the bugfix/vfs-folder-detection branch from 7b9d4aa to 6f901a6 Compare December 12, 2024 08:51
TheOneRing and others added 7 commits December 12, 2024 12:15
@TheOneRing @mgallien
Fix network drive detection
0fa84e9 
We can't rely on the file system detection because Windows is reporting the underlying file system.

Fixes: #8272
@TheOneRing @mgallien
Fix crash on missing sync root
47132d3 
Fixes: #9016
@TheOneRing @mgallien
Warn if we encounter an unsupported configuration
cb05ced
@camilasan @mgallien
Update tests for folder check to match fix.
638f3a8 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @mgallien
Remove unused variable.
f9ec738 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @mgallien
Add [[nodiscard]] to functions.
7581f29 
Signed-off-by: Camila Ayres <hello@camilasan.com>
@camilasan @mgallien
All conditions must be true to use virtual files in the selected loca…
d3d7963 
…tion.

Signed-off-by: Camila Ayres <hello@camilasan.com>
@mgallien mgallien force-pushed the bugfix/vfs-folder-detection branch from 3b48e3a to d3d7963 Compare December 12, 2024 11:15
@mgallien mgallien enabled auto-merge December 12, 2024 11:16
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
41.7% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
1 New Bugs (required ≤ 0)
E Reliability Rating on New Code (required ≥ A)
129 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7636-d3d7963dc0597cfd105adeaf3b0313d9b1a69010-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien disabled auto-merge December 12, 2024 13:27
@mgallien mgallien merged commit e01d0f8 into master Dec 12, 2024
12 of 16 checks passed
@mgallien mgallien deleted the bugfix/vfs-folder-detection branch December 12, 2024 13:27
@backportbot backportbot bot mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@claucambra claucambra Awaiting requested review from claucambra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.15.1
Development

Successfully merging this pull request may close these issues.
4 participants
@camilasan @nextcloud-desktop-bot @mgallien @TheOneRing