Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plural forms handling correction to notification message #7904

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

Pabarino
Copy link
Contributor

@Pabarino Pabarino commented Feb 20, 2025

Corrected the way the plural forms was being handled according to the Qt documentation for better translation:
https://doc.qt.io/qt-6/i18n-source-translation.html
Would fix issue #7887

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the parentheses are not necessary here

@claucambra claucambra added this to the 3.16.0 milestone Feb 21, 2025
@nilsding nilsding linked an issue Feb 21, 2025 that may be closed by this pull request
@Pabarino
Copy link
Contributor Author

Okay, I removed the parenthesis and added the nullptr

Signed-off-by: Pablo Ariño Muñoz <progpabarino@gmail.com>
Signed-off-by: Pablo Ariño Muñoz <progpabarino@gmail.com>
@claucambra claucambra merged commit e11bc82 into nextcloud:master Feb 24, 2025
9 of 13 checks passed
@claucambra
Copy link
Collaborator

/backport to stable-3.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add plural
2 participants