Debian/Ubuntu target repository update #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivaradi
changed the title
rullzer
approved these changes
Nov 14, 2018
|
@rullzer thanks for approving. Now, this change works as intended only if tagging triggers a build. Otherwise each version is built only when it is not yet tagged, so only the beta PPA is updated. Could we congfigure the Drone server to build also for tags? |
|
@ivaradi I'll see what I can do |
|
@rullzer if I understand the settings page (https://drone.nextcloud.com/nextcloud/desktop/settings) correctly, there is an option there for it. I am just wondering if enabling it would cause any problems. |
|
Done we now also build on tag. Beside using some extra CI I do not think this is an issue :) |
|
@rullzer Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the build script uploaded the source packages to the beta repositories (PPAs for Ubuntu).
However, with tagging resumed, it would be useful to upload the package for release versions to the stable repository. This patches update the build script to do so. If the version being built is tagged with a release tag (such as "v2.5.0"), it is considered a stable version and thus uploaded to the stable repository. Otherwise it goes to the beta one.