-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds server based on latest master #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me.
@MorrisJobke any comments here?
Yesterday I noticed that this one had some bugs ... for example are thumbnails broken and not generated. So I migrated my local docker image to be Debian based and have less selfcompiled stuff, but relies more on the real world instances (a Debian with standard packages that are out there).
opcache.enable=1
opcache.enable_cli=1
opcache.interned_strings_buffer=8
opcache.max_accelerated_files=10000
opcache.memory_consumption=128
opcache.save_comments=1
opcache.revalidate_freq=1 My entry point script (basically loads the default environment variables of apache and starts it in the foreground):
|
server/Dockerfile
Outdated
RUN chsh -s /bin/bash www-data | ||
|
||
ADD init.sh /initnc.sh | ||
RUN chmod +x /initnc.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply this to the file and git commit
this then ;)
server/Dockerfile
Outdated
|
||
WORKDIR /var/www/html | ||
|
||
RUN git clone https://github.com/nextcloud/server.git nc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you cloning to nc
and not to the working dir directly. Then there wouldn't be a need to have it in a subdir like localhost/nc
;)
server/Dockerfile
Outdated
RUN git clone https://github.com/nextcloud/server.git nc | ||
RUN cd nc && git submodule update --init | ||
RUN chown -R www-data:www-data nc | ||
RUN chsh -s /bin/bash www-data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any need for this? You could also simply run the process in the container as root ... there isn't anything other in this container anyways ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roeland said that it was not working if /nc is not owned by apache user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if you run apache as root it is owned by it ;) At least that is what works totally fine over here ;)
server/init.sh
Outdated
cd /var/www/html/nc | ||
|
||
#Update code | ||
su www-data -c " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also you don't need to do this hack if you run apache as root ;)
@MorrisJobke I removed now the www-data stuff, but now I get an internal error, when accessing server. |
@MorrisJobke is seems that it has to be run as www-data. |
Looks good so far. Just try it then you know if it works ;) |
This is now working for me 👍 |
server/init.sh
Outdated
php occ config:system:set trusted_domains 1 --value=* | ||
" | ||
|
||
bash apache2-foreground |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really? Just copy paste it in here ;)
This image pulls always latest master and install it at /nc.
Also a test user with "test" password is created.
THis is needed for automated testing on android, as it needs a server to do basic operations on it.
All credits belong to @rullzer