-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ephemeral instead of manual/persistent lock during upgrade #1756
Comments
8 tasks
meonkeys
added a commit
to meonkeys/nextcloud-docker
that referenced
this issue
May 21, 2022
meonkeys
added a commit
to meonkeys/nextcloud-docker
that referenced
this issue
May 22, 2022
fix nextcloud#1756 Signed-off-by: Adam Monsen <haircut@gmail.com>
see #1760 for another approach |
Note to self: put the lockfile in |
meonkeys
added a commit
to meonkeys/nextcloud-docker
that referenced
this issue
Feb 8, 2023
meonkeys
added a commit
to meonkeys/nextcloud-docker
that referenced
this issue
Feb 8, 2023
fix nextcloud#1756 Signed-off-by: Adam Monsen <haircut@gmail.com>
meonkeys
added a commit
to meonkeys/nextcloud-docker
that referenced
this issue
Feb 8, 2023
fix nextcloud#1756 fix nextcloud#1903 Signed-off-by: Adam Monsen <haircut@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
docker-entrypoint.sh
manually creates a file and uses this to indicate an in-progress upgrade. Manual intervention is required if the upgrade fails halfway andnextcloud-init-sync.lock
is neverrm
'd. How about if we use an automaticflock
instead? There's example code in theflock(1)
manual page:We should be able to just surround all upgrade code like that example, and get rid of
touch $lock
,if [ -f "$lock" ]; then
andrm $lock
indocker-entrypoint.sh
.Thoughts?
The text was updated successfully, but these errors were encountered: