replace build image with bind mount #2278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SebastianRzk <github@sebastianruziczka.de>
|
I agree here. I would also move the configuration file outside of the "web" directory or just rename the web directory to "conf" one. This has the good side effect that will allow using that same "conf" directory for other stuff, like mounting mime-types; Nextcloud's own configuration there in the case of bind mounts; proxy related configurations; even in my use case - Nexcloud's container configs like EDIT: Docker on Windows now use WSL2, so no problems with #538 anymore. Also, the non-root nginx image is a very good idea as well. |
|
Agreed 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A separate image is currently being built for the nginx proxy (service name: web). According to my information, this is not necessary, but even counterproductive
Why?