Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Alpine Linux in examples and use default user on nginx containers #538

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Nov 15, 2018

No description provided.

@J0WI
Copy link
Contributor Author

J0WI commented Nov 15, 2018

We could also drop all the custom Dockerfiles and just mount the configs, but I'm not sure how this behaves with relative paths.

@SnowMB
Copy link
Contributor

SnowMB commented Nov 15, 2018

The custom Dockerfiles were introduced because of problems with docker for windows and the virtual machine running docker. I don't know what's the current status on this.

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@tilosp
Copy link
Member

tilosp commented Nov 20, 2018

@J0WI i generally like the idea of switching to alpine in our examples.

but i think this would break existing setups when the new docker-compose.yml is pulled, because the www-data user has a different id under alpine.

@J0WI
Copy link
Contributor Author

J0WI commented Nov 20, 2018

I could revert the fpm-alpine change, but I think the examples are for new users to play with the image. People should not relay on the examples for production usage without making adjustments for their personal use case (I think they are forced to set at least a database password). Otherwise we could never modernize the examples.

Copy link
Member

@tilosp tilosp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, the user has to at least adjust the db password which makes pulling a new version impossible

@tilosp tilosp merged commit 0c16d10 into nextcloud:master Nov 20, 2018
@J0WI J0WI deleted the alpine-eg branch November 20, 2018 22:21
@gwarf
Copy link

gwarf commented Nov 21, 2018

I've been using (and I'm probably not the only one) the .examples/docker-compose/with-nginx-proxy/mariadb-cron-redis/fpm examples very happily to run my nextcloud instance, I'm used to git stash, git pull and git stash pop to keep/update/re-apply my small required changes (ie. only MYSL_ROOT_PASSWORD, VIRTUAL_HOST, LETSENCRYPT_HOST and LETSENCRYPT_EMAIL). Is it possible to get some advice on how to handle the changes that this PR introduced?

@J0WI
Copy link
Contributor Author

J0WI commented Nov 21, 2018

@gwarf in your case, you need to chown gid and uid to 82 in your nextcloud volume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants