Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map configs via volumes instead of build new image #559

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

avaika
Copy link

@avaika avaika commented Nov 29, 2018

Wasn't sure if this will be accepted, thus did the change only for proxy-mariadb and proxy-postgres images. Can do the rest as well, but want to be sure that it won't be just waste of time.

PS. Also added a workaround for #345

Signed-off-by: rush <github@avaika.me>
Signed-off-by: rush <github@avaika.me>
Signed-off-by: rush <github@avaika.me>
Signed-off-by: rush <github@avaika.me>
Signed-off-by: rush <github@avaika.me>
@J0WI
Copy link
Contributor

J0WI commented Dec 5, 2018

This has already been discussed here: #538 (comment)

@SnowMB could you give more details about this issue and how we can test this?

@J0WI J0WI added examples Compose/Dockerfile/etc enhancement labels Dec 5, 2018
@J0WI J0WI requested a review from SnowMB December 13, 2018 13:07
@J0WI
Copy link
Contributor

J0WI commented Apr 29, 2019

🏓 @SnowMB

@SnowMB
Copy link
Contributor

SnowMB commented May 17, 2019

Would love to help in this regard, but I can't. I have no windows machine to test this out. But I can point you to the corresponding issues / commits:

Initial problems came from #104. And I discussed this with @tilosp in #125 (comment)

I don't know if this is still relevant as I see many other images mounting config files, too.

@J0WI
Copy link
Contributor

J0WI commented Nov 6, 2019

@tilosp are you fine with dropping the homebrew proxy containers?

@J0WI J0WI requested a review from tilosp November 6, 2019 10:36
@J0WI
Copy link
Contributor

J0WI commented Nov 6, 2019

@avaika could you rebase your PR?

@tilosp
Copy link
Member

tilosp commented Nov 6, 2019

This will not work if the docker client is on a different machine than the docker host.
Because the docker host needs to mount the config files but they are only available on the client machine.
This is for example the case on docker for windows (in Linux container mode). There the client runs under windows and the docker host is a linux vm.

I don't see any other benefits to this pr other than not having to run docker-compose build.
Am i missing something?

So we have to decide whether we want to support remote docker hosts or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement examples Compose/Dockerfile/etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants