-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
map configs via volumes instead of build new image #559
Conversation
Signed-off-by: rush <github@avaika.me>
Signed-off-by: rush <github@avaika.me>
Signed-off-by: rush <github@avaika.me>
Signed-off-by: rush <github@avaika.me>
Signed-off-by: rush <github@avaika.me>
This has already been discussed here: #538 (comment) @SnowMB could you give more details about this issue and how we can test this? |
🏓 @SnowMB |
Would love to help in this regard, but I can't. I have no windows machine to test this out. But I can point you to the corresponding issues / commits: Initial problems came from #104. And I discussed this with @tilosp in #125 (comment) I don't know if this is still relevant as I see many other images mounting config files, too. |
@tilosp are you fine with dropping the homebrew proxy containers? |
@avaika could you rebase your PR? |
This will not work if the docker client is on a different machine than the docker host. I don't see any other benefits to this pr other than not having to run So we have to decide whether we want to support remote docker hosts or not. |
closing this. discussion in #2279 |
Wasn't sure if this will be accepted, thus did the change only for proxy-mariadb and proxy-postgres images. Can do the rest as well, but want to be sure that it won't be just waste of time.
PS. Also added a workaround for #345