Explicitly set locale settings #1459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kurzdev <jpack1.0@hotmail.com>
|
Looks good to me, But I'd prefer to double check with other maintainers. |
pierreozoux
approved these changes
Mar 26, 2021
|
I can't reproduce the issue in #721 and therefore can hardly review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of right now, this only works on non-alpine images, as
localeis not yet supported by Alpine Linux. Therefore, only changes to the debian template have been made. There are some workarounds for Alpine as well (as seen here), but this seems a little too hacky for me and maybe even unnecessary. Would be nice if someone with more experience could comment on that.Fixes #721