Added fetching autoconfig data from Docker secrets #1515
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: S <s@local>
Signed-off-by: S <s@local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve #1148
This is my first PR. I'm not very familiar with Docker, however, I hope that this solves the issue.
I changed only
.config/autoconfig.php, as far as I can understand these changes should propagate to, say,21.0/apache/config/autoconfig.phpautomatically.Please correct me if I'm wrong.
Another question to consider is the security of
trim(file_get_contents(getenv('MYSQL_DATABASE_FILE')));. Theoretically, it is possible to specify any file, however, the very same approach is used inentrypoint.sh. Both the installation script and Docker secrets should be controlled by a privileged user. I see no issues with this, however, I'm not a security expert and thus I request a second opinion.