Block upgrade if it is not supported because major versions are too different #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes nextcloud#1809. This prevents the install from getting in a state where none of the Docker images will accept running given the contents of the volumes. Signed-off-by: Antonin Delpeuch <antonin@delpeuch.eu>
wetneb
force-pushed
the
1809-block-upgrade-if-unsupported
branch
from
b834894 to
c832a05
Compare
This was referenced Jun 24, 2023
|
@J0WI what do you think of this? It seems to have been reported many times and there has already been a PR (#1304) proposing basically the same fix (which I discovered after writing this one). |
|
Push! |
J0WI
reviewed
Jul 7, 2023
Co-authored-by: J0WI <J0WI@users.noreply.github.com> Signed-off-by: Antonin Delpeuch <antonin@delpeuch.eu>
Co-authored-by: J0WI <J0WI@users.noreply.github.com> Signed-off-by: Antonin Delpeuch <antonin@delpeuch.eu>
J0WI
requested changes
Jul 8, 2023
Signed-off-by: Antonin Delpeuch <antonin@delpeuch.eu>
Co-authored-by: J0WI <J0WI@users.noreply.github.com> Signed-off-by: Antonin Delpeuch <antonin@delpeuch.eu>
wetneb
force-pushed
the
1809-block-upgrade-if-unsupported
branch
from
9f399e8 to
6684153
Compare
J0WI
approved these changes
Jul 9, 2023
|
Thanks for your work! :) |
Closed
9 tasks
4 tasks
ananace
pushed a commit
to ananace/docker-nextcloud
that referenced
this pull request
May 10, 2024
…ifferent (nextcloud#2018) * Block upgrade if it is not supported Closes nextcloud#1809. This prevents the install from getting in a state where none of the Docker images will accept running given the contents of the volumes. Signed-off-by: Antonin Delpeuch <antonin@delpeuch.eu> * Update docker-entrypoint.sh Co-authored-by: J0WI <J0WI@users.noreply.github.com> Signed-off-by: Antonin Delpeuch <antonin@delpeuch.eu> * Update docker-entrypoint.sh Co-authored-by: J0WI <J0WI@users.noreply.github.com> Signed-off-by: Antonin Delpeuch <antonin@delpeuch.eu> * Remove extra function Signed-off-by: Antonin Delpeuch <antonin@delpeuch.eu> * Update docker-entrypoint.sh Co-authored-by: J0WI <J0WI@users.noreply.github.com> Signed-off-by: Antonin Delpeuch <antonin@delpeuch.eu> --------- Signed-off-by: Antonin Delpeuch <antonin@delpeuch.eu> Co-authored-by: J0WI <J0WI@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1809. Closes #1129. Closes #616. Closes #617.
This prevents the install from getting in a state where none of the Docker images will accept running given the contents of the volumes (see issue).
So far, the warning mentioned in
https://github.com/nextcloud/docker#update-to-a-newer-version
was not actually enforced in the docker image.