Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use var PHP_OPCACHE_MEMORY_CONSUMPTION for configuration #2090

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use var PHP_OPCACHE_MEMORY_CONSUMPTION for configuration #2090

wants to merge 2 commits into from

Conversation

tclavier
Copy link
Contributor

No description provided.

@tclavier
use var PHP_OPCACHE_MEMORY_CONSUMTION for configuration
a53f275 
Signed-off-by: Thomas Clavier <tom@tcweb.org>
@tclavier
Use PHP_OPCACHE_MEMORY_CONSUMTION in Dockerfile-alpine.template
b4bc66d 
Signed-off-by: Thomas Clavier <tom@tcweb.org>
@jjasoncool
Copy link

jjasoncool commented Nov 29, 2023 •
edited
Loading

I think maybe using "sed" to change original files?
https://github.com/nextcloud/docker/blob/master/27/fpm/Dockerfile#L99-L103

@tclavier
Copy link
Contributor Author

using sed in startup script to replace opcache.memory_consumption=128 by opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMTION} ?

@jjasoncool
Copy link

using sed in startup script to replace opcache.memory_consumption=128 by opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMTION} ?

Sorry, That all version was build by template files, your code is right.
But I think that can also add ENV jit_buffer_size also.

@J0WI
Copy link
Contributor

J0WI commented Jan 9, 2024

This requires some documentation in the README.

joshtrichards
joshtrichards reviewed Feb 8, 2024
View reviewed changes
Dockerfile-alpine.template
RUN { \
echo 'opcache.enable=1'; \
echo 'opcache.interned_strings_buffer=32'; \
echo 'opcache.max_accelerated_files=10000'; \
echo 'opcache.memory_consumption=128'; \
echo 'opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMTION}'; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo 'opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMTION}'; \
echo 'opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMPTION}'; \

joshtrichards
joshtrichards reviewed Feb 8, 2024
View reviewed changes
Dockerfile-debian.template
@@ -95,7 +96,7 @@ RUN { \
echo 'opcache.enable=1'; \
echo 'opcache.interned_strings_buffer=32'; \
echo 'opcache.max_accelerated_files=10000'; \
echo 'opcache.memory_consumption=128'; \
echo 'opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMTION}'; \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo 'opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMTION}'; \
echo 'opcache.memory_consumption=${PHP_OPCACHE_MEMORY_CONSUMPTION}'; \

joshtrichards
joshtrichards reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to support opcache changes like this, we should probably also support opcache.max_accelerated_files and opcache.interned_strings_buffer since they're all part of the same setup checks in Server. Otherwise it'll be an incomplete enhancement.

@joshtrichards joshtrichards changed the title use var PHP_OPCACHE_MEMORY_CONSUMTION for configuration use var PHP_OPCACHE_MEMORY_CONSUMPTION for configuration Feb 8, 2024
@J0WI
Copy link
Contributor

J0WI commented Apr 2, 2024

See also #2185 (comment)

@markuman markuman mentioned this pull request Jun 18, 2024
Closed
jessebot
jessebot reviewed Jul 29, 2024
View reviewed changes
Dockerfile-debian.template
@@ -20,6 +20,7 @@ RUN set -ex; \
# see https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html
ENV PHP_MEMORY_LIMIT 512M
ENV PHP_UPLOAD_LIMIT 512M
ENV PHP_OPCACHE_MEMORY_CONSUMTION 128
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ENV PHP_OPCACHE_MEMORY_CONSUMTION 128
ENV PHP_OPCACHE_MEMORY_CONSUMPTION 128

jessebot
jessebot reviewed Jul 29, 2024
View reviewed changes
Dockerfile-alpine.template
@@ -79,11 +79,12 @@ RUN set -ex; \
# see https://docs.nextcloud.com/server/latest/admin_manual/installation/server_tuning.html#enable-php-opcache
ENV PHP_MEMORY_LIMIT 512M
ENV PHP_UPLOAD_LIMIT 512M
ENV PHP_OPCACHE_MEMORY_CONSUMTION 128
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ENV PHP_OPCACHE_MEMORY_CONSUMTION 128
ENV PHP_OPCACHE_MEMORY_CONSUMPTION 128

@jessebot
Copy link
Contributor

This is a common request downstream in nextcloud/helm. If this PR was re-submitted with the suggested fixes here, would it still be viable? I see there was conversation #2185, but I can't tell if that means this PR should be closed?

@J0WI
Copy link
Contributor

J0WI commented Sep 18, 2024

Is it only about the memory_consumption setting?

@J0WI
Copy link
Contributor

J0WI commented Oct 8, 2024

see also #2275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessebot jessebot jessebot left review comments

@joshtrichards joshtrichards joshtrichards left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tclavier @jjasoncool @J0WI @jessebot @joshtrichards