Add dbindex to redis.config.php

[Hujgo]

add dbindex for redis as comment. referenced from a6f2a3c commit.

[joshtrichards]

That's not a comment. :-)

Also, this would have to be handled in the PHP session handler too otherwise the result might not be what people expect...

docker/docker-entrypoint.sh

Lines 108 to 133 in 064069b

	if [ -n "${REDIS_HOST+x}" ]; then
	echo "Configuring Redis as session handler"
	{
	file_env REDIS_HOST_PASSWORD
	echo 'session.save_handler = redis'
	# check if redis host is an unix socket path
	if [ "$(echo "$REDIS_HOST" | cut -c1-1)" = "/" ]; then
	if [ -n "${REDIS_HOST_PASSWORD+x}" ]; then
	echo "session.save_path = \"unix://${REDIS_HOST}?auth=${REDIS_HOST_PASSWORD}\""
	else
	echo "session.save_path = \"unix://${REDIS_HOST}\""
	fi
	# check if redis password has been set
	elif [ -n "${REDIS_HOST_PASSWORD+x}" ]; then
	echo "session.save_path = \"tcp://${REDIS_HOST}:${REDIS_HOST_PORT:=6379}?auth=${REDIS_HOST_PASSWORD}\""
	else
	echo "session.save_path = \"tcp://${REDIS_HOST}:${REDIS_HOST_PORT:=6379}\""
	fi
	echo "redis.session.locking_enabled = 1"
	echo "redis.session.lock_retries = -1"
	# redis.session.lock_wait_time is specified in microseconds.
	# Wait 10ms before retrying the lock rather than the default 2ms.
	echo "redis.session.lock_wait_time = 10000"
	} > /usr/local/etc/php/conf.d/redis-session.ini
	fi

[joshtrichards]

Suggested change

	'dbindex' => (int) getenv('REDIS_DB_INDEX'),
	// 'dbindex' => (int) getenv('REDIS_DB_INDEX'),

[J0WI]

having this in the autoconfig but commented out is pretty useless IMHO. Why did they add it like this in AIO?

[J0WI]

kind of duplictae of #1286

Can you elaborate the use case?

[GroondCharge]

Can you elaborate the use case?

Having an external redis master-master cluster and deploying nextcloud only on designated node. I am aware that prefix hash is calculated by concatenating instanceid, path and version, so in theory there should be no conflicting prefixes, however being able to separate it in separate dbindices in case of needing to cleanup after update etc. is a bonus, especially if you're managing mutliple instances connecting to single cluster. One of the solutions would be having option to use consistent prefix for redis entries.

[GroondCharge]

If this will get pulled into main, has the session lock configuration been adjusted aswell? I've tried an example here https://github.com/nextcloud/docker/pull/2288/files

[joshtrichards]

Having an external redis master-master cluster and deploying nextcloud only on designated node

But Redis Cluster doesn't support dbindex / multiple databases.

https://redis.io/docs/latest/commands/select/