Disable absolute redirect #2314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tommy <contact@tommytran.io>
|
The example also uses port 80 and we take the configuration from https://github.com/nextcloud/documentation/blob/master/admin_manual/installation/nginx-root.conf.sample |
|
It doesn't matter though, when you are using an app behind a reverse proxy (as is the case of nginx in this stack) it is expected that relative redirect is used instead of absolute redirect. Absolute redirect should be disabled for correctness. I wasted quite a lot of time debugging weird error because of this and I see no reason to not do it to save other people the trouble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absolute redirect should be disabled. Currently, it only works by chance because the
webcontainer is listening on port 80.If you try to change the port to something like 8080, the 301 redirect for things like caldav and carddav will be broken.