Redis patch #735
Closed
Redis patch #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0WI
reviewed
Jun 18, 2019
| @@ -25,7 +25,11 @@ if expr "$1" : "apache" 1>/dev/null || [ "$1" = "php-fpm" ] || [ "${NEXTCLOUD_UP | |||
| echo "Configuring Redis as session handler" | |||
| { | |||
| echo 'session.save_handler = redis' | |||
| echo "session.save_path = \"tcp://${REDIS_HOST}:${REDIS_HOST_PORT:=6379}\"" | |||
| if [[ ${REDIS_HOST:0:1} == "/" ]] ; then | |||
| echo "session.save_path = \"unix://${REDIS_HOST}?persistent=1&weight=1&database=0\"" | |||
There was a problem hiding this comment.
Are these extra arguments required for sockets?
tortuetorche
added a commit
to tortuetorche/docker
that referenced
this pull request
Dec 16, 2019
Rebase and rewrite the @epma01 pull request, based on last Nextcloud Docker changes See: nextcloud#735
tortuetorche
added a commit
to tortuetorche/docker
that referenced
this pull request
Dec 16, 2019
Rebase and rewrite the @epma01 pull request, based on last Nextcloud Docker changes See: nextcloud#735 Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
tortuetorche
added a commit
to tortuetorche/docker
that referenced
this pull request
Jan 9, 2020
Rebase and rewrite the @epma01 pull request, based on last Nextcloud Docker changes See: nextcloud#735 Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
J0WI
pushed a commit
that referenced
this pull request
Jan 10, 2020
* Fix Redis Unix socket support Rebase and rewrite the @epma01 pull request, based on last Nextcloud Docker changes See: #735 Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com> * Fix CI tests with update.sh script Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Craeckie
pushed a commit
to Craeckie/nextcloud-docker-full
that referenced
this pull request
Mar 30, 2022
* Fix Redis Unix socket support Rebase and rewrite the @epma01 pull request, based on last Nextcloud Docker changes See: nextcloud/docker#735 Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com> * Fix CI tests with update.sh script Signed-off-by: Tortue Torche <tortuetorche@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Broken Redis session handler with unix socket #730
Without more patches redis can be used now in socket mode, setting REDIS_HOST to socket path and REDIS_HOST_PORT to 0
The RedisFactory.php server file must be patched if we want to avoid having to establish REDIS_HOST_PORT