Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(user_manual): document system address book #10264

Merged
merged 1 commit into from
May 12, 2023
Merged

feat(user_manual): document system address book #10264

merged 1 commit into from
May 12, 2023

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented May 4, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

Before After
screencapture-127-0-0-1-8000-userpreferences-html-2023-05-04-16_51_34 screencapture-127-0-0-1-8000-userpreferences-html-2023-05-04-16_47_45
screencapture-127-0-0-1-8000-groupware-contacts-html-2023-05-04-16_50_48 screencapture-127-0-0-1-8000-groupware-contacts-html-2023-05-04-16_48_24

@miaulalala miaulalala added this to the Nextcloud 27 milestone May 4, 2023
@miaulalala miaulalala self-assigned this May 4, 2023
@ChristophWurst
Copy link
Member

There is no documentation that wouldn't be true with the current SAB implementation. We can already merge this PR, even if nextcloud/server#37734 is not in yet.

@ChristophWurst
Copy link
Member

Conventional commits are not checked here but fyi feat(user_manual) is an invalid scope. I know because I made the mistake myself until @st3iny pointed it out. The scope should only be alphanumeric, so feat(usermanual)

👻

@ChristophWurst ChristophWurst marked this pull request as ready for review May 12, 2023 07:13
@miaulalala
feat(user_manual): document system address book
b189035 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the enh/user_manual/document-system-addressbook branch from cd642da to b189035 Compare May 12, 2023 12:19
@ChristophWurst
Copy link
Member

we have not branched off yet, master=27

@ChristophWurst ChristophWurst merged commit 1496839 into master May 12, 2023
@ChristophWurst ChristophWurst deleted the enh/user_manual/document-system-addressbook branch May 12, 2023 12:52
@joshtrichards joshtrichards mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@hamza221 hamza221 Awaiting requested review from hamza221 hamza221 is a code owner

Assignees

@miaulalala miaulalala

Labels
3. to review manual: user waiting for code merge
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.

Document system addressbook
2 participants
@miaulalala @ChristophWurst