Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document some phpdoc return type changes in OCP in 27 #10513

Merged
merged 1 commit into from
May 31, 2023
Merged

Document some phpdoc return type changes in OCP in 27 #10513

merged 1 commit into from
May 31, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented May 30, 2023 •
edited
Loading

@come-nc come-nc added this to the Nextcloud 27 milestone May 30, 2023
@come-nc come-nc self-assigned this May 30, 2023
@come-nc come-nc requested review from nickvergessen and blizzz May 30, 2023 12:10
@come-nc
Copy link
Contributor Author

come-nc commented May 30, 2023

Not sure I put this in the right place actually, what does Client API means? Should I add a Changed API section to backend changes instead?

@nickvergessen
Copy link
Member

Not sure I put this in the right place actually, what does Client API means?

Should be in Back-end changes not Client API (OCS end points)

Should I add a Changed API section to backend changes instead?

Yes

@come-nc
Copy link
Contributor Author

come-nc commented May 30, 2023

Screenshot_20230530_143504

@come-nc
Copy link
Contributor Author

come-nc commented May 30, 2023

/backport to stable27

@come-nc
Document some phpdoc return type changes in OCP in 27
d35cf3c 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/document-return-type-fixes-in-ocp-27 branch from afc44aa to d35cf3c Compare May 30, 2023 14:26
@nickvergessen nickvergessen merged commit b0610b7 into master May 31, 2023
@nickvergessen nickvergessen deleted the fix/document-return-type-fixes-in-ocp-27 branch May 31, 2023 09:10
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 31, 2023
Merged
@nickvergessen nickvergessen mentioned this pull request May 31, 2023
Merged
@blizzz
Copy link
Member

blizzz commented May 31, 2023

master is 28

@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@come-nc come-nc

Labels
3. to review
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @nickvergessen @blizzz