Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(upgrade_to_30): add line-height change docs #12082

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

docs(upgrade_to_30): add line-height change docs #12082

wants to merge 2 commits into from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 1, 2024

@ShGKme
docs(upgrade_to_30): add line-height change docs
8e594d5 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added this to the Nextcloud 30 milestone Aug 1, 2024
@ShGKme ShGKme self-assigned this Aug 1, 2024
Antreesy
Antreesy reviewed Aug 1, 2024
View reviewed changes
developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst Outdated Show resolved Hide resolved
developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst Outdated
}

element2 {
font-size: calc(var(--default-font-size), 2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
font-size: calc(var(--default-font-size), 2);
font-size: calc(var(--default-font-size) * 2);

Or I didn't get whether it was a multiplier or fallback value

susnux
susnux previously approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detailed changelog 😍

@susnux susnux dismissed their stale review August 1, 2024 11:51

did not check it works

@susnux
fixup: Adjust code to rst syntax
0d3bd06 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
Copy link
Contributor

susnux commented Aug 1, 2024

Screenshot 2024-08-01 at 15-22-31 Upgrade to Nextcloud 30 — Nextcloud latest Developer Manual latest documentation

@susnux
Copy link
Contributor

susnux commented Aug 15, 2024

/backport to stable30

@nickvergessen
Copy link
Member

Conflicting files
developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux left review comments

@Antreesy Antreesy Antreesy approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

Assignees

@ShGKme ShGKme

Labels
2. developing backport-request manual: developer
Projects
None yet
Milestone
Nextcloud 30.0.1
Development

Successfully merging this pull request may close these issues.
6 participants
@ShGKme @susnux @nickvergessen @marcoambrosini @Antreesy @Altahrim