This repository was archived by the owner on Nov 13, 2024. It is now read-only.
fix(Drone): fix broken list when stored build is unavailable #42
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DroneCI replies with a 404 when a build is not in the list anymore. So we return an empty BuildInfo object with a custom status. What is still missing is a cleanup of the DB table with prioritized builds. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
nickvergessen
approved these changes
Nov 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DroneCI replies with a 404 when a build is not in the list anymore. So we return an empty BuildInfo object with a custom status.
What is still missing is a cleanup of the DB table with prioritized builds.