feat: Validate keyChecksum length

Signed-off-by: Louis Chemineau <louis@chmn.me>
nextcloud · Jan 9, 2025 · c312090 · c312090
1 parent af20670
commit c312090
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/services/metadataUtils.ts b/src/services/metadataUtils.ts
@@ -22,14 +22,21 @@ export async function decryptMetadataInfo(metadata: Metadata, metadataPrivateKey
 		{ iv: base64ToBuffer(iv) },
 	)
 
-	const metadataInfo = JSON.parse(await unzipBuffer(compressedMetadataInfo))
+	const metadataInfo = JSON.parse(await unzipBuffer(compressedMetadataInfo)) as MetadataInfo
 
-	verifyMetadataKey(metadataInfo, metadataPrivateKey)
+	validateKeyChecksums(metadataInfo, metadata)
+	validateMetadataKey(metadataInfo, metadataPrivateKey)
 
 	return metadataInfo
 }
 
-export async function verifyMetadataKey(metadataInfo: MetadataInfo, metadataPrivateKey: CryptoKey): Promise<void> {
+function validateKeyChecksums(metadataInfo: MetadataInfo, metadata: Metadata): void {
+	if (metadataInfo.keyChecksums?.length !== metadata.users?.length) {
+		throw new Error('Key checksums length does not match users length')
+	}
+}
+
+export async function validateMetadataKey(metadataInfo: MetadataInfo, metadataPrivateKey: CryptoKey): Promise<void> {
 	if (metadataInfo.keyChecksums === undefined) {
 		return
 	}