tests: Add test for mimetype blocking on share #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
juliusknorr
commented
Mar 13, 2023
•
juliusknorr
commented
- test case for fix: Avoid failing with duplicate checks server#36830
- add cases for existing code around this change Also check the path based mimetype for flow rule checks server#23096 Only execute plain mimetype check for directories and do the fallback… server#24459
- Remove last TMP commit once fix: Avoid failing with duplicate checks server#36830 is merged
juliusknorr
force-pushed
the
tests/36830
branch
from
a0c7d45 to
17a1a83
Compare
juliusknorr
force-pushed
the
tests/36830
branch
3 times, most recently
from
9081722 to
80969c5
Compare
Merged
nickvergessen
force-pushed
the
integration-tests
branch
2 times, most recently
from
5e9d36a to
0468063
Compare
juliusknorr
force-pushed
the
tests/36830
branch
2 times, most recently
from
02423f2 to
c9fba5e
Compare
juliusknorr
force-pushed
the
tests/36830
branch
from
c9fba5e to
b3245ae
Compare
4 tasks
blizzz
reviewed
Jul 12, 2023
| * @param array $arrayOfArrays | ||
| * @return array | ||
| */ | ||
| public function simplifyArray($arrayOfArrays) { |
There was a problem hiding this comment.
I think I added for completeness as there were usages from Joas initial commit:
tests/Integration/features/bootstrap/WebDav.php
579: $elementsSimplified = $this->simplifyArray($elementRows);
930: $elementsSimplified = $this->simplifyArray($elementRows);
nickvergessen
approved these changes
Jul 17, 2023
Signed-off-by: Julius Härtl <jus@bitgrid.net> test: Add pdf data for integration tests Signed-off-by: Julius Härtl <jus@bitgrid.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.