Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly check part file sizes on upload #581

Closed
wants to merge 1 commit into from

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 14, 2024

Fix #580

This is partially reverting #330. Not sure about this one because of potential side effects.

About scanning part files:

Their name is not the final, the size is wrong, tags are missing, etc.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny requested a review from nickvergessen August 14, 2024 09:18
@st3iny st3iny self-assigned this Aug 14, 2024
@nickvergessen
Copy link
Member

And as the tests show, it breaks legit rules used by customers :D

@st3iny st3iny closed this Aug 16, 2024
@nickvergessen nickvergessen deleted the fix/part-upload-limit-size branch August 16, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File upload limited by size is blocked after assembling chunks
2 participants