Skip to content

Fix lint checks on PHP 7.3 CI #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 13, 2022
Merged

Fix lint checks on PHP 7.3 CI #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83c703c
Fix lint check on PHP 7.3
Pytal Apr 5, 2022
82ff352
Ignore christophwurst/nextcloud requirement for PHP ^7.2
Pytal Apr 5, 2022
3a9a6bc
Fix dependency conflict
Pytal Apr 5, 2022
f23859b
Improve matrix
nickvergessen Apr 5, 2022
4d78db9
Fix typo
nickvergessen Apr 5, 2022
770b016
install ocp without composer.lock
icewind1991 Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,32 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ['7.3', '7.4', '8.0']
name: php${{ matrix.php-versions }} lint
php-version: ['7.4', '8.0']
ocp-version: ['^v21.0.0', '^v22.0.0', '^v23.0.0', 'dev-master']
include:
- php-version: '7.3'
ocp-version: '^v21.0.0'
- php-version: '7.3'
ocp-version: '^v22.0.0'
- php-version: '7.3'
ocp-version: '^v23.0.0'
- php-version: '8.1'
ocp-version: 'dev-master'
name: php${{ matrix.php-version }}-ocp-${{ matrix.ocp-version }} lint
steps:
- name: Checkout
uses: actions/checkout@master
- name: Set up php${{ matrix.php-versons }}
- name: Set up php${{ matrix.php-version }}
uses: shivammathur/setup-php@master
with:
php-version: ${{ matrix.php-versions }}
php-version: ${{ matrix.php-version }}
coverage: none
- name: Install dependencies
run: composer i
run: composer i --ignore-platform-reqs
- name: Install OCP package
run: |
rm composer.lock
composer require --dev christophwurst/nextcloud:${{ matrix.ocp-version }}
- name: Lint
run: composer run lint

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"require-dev": {
"christophwurst/nextcloud": "dev-master",
"christophwurst/nextcloud": "^v20.0.0",
"php-parallel-lint/php-parallel-lint": "^1.0",
"phpunit/phpunit": "^8",
"nextcloud/coding-standard": "^0.4.0"
Expand Down