Scanner improvements #334
Merged
Scanner improvements #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
icewind1991
commented
May 21, 2024
icewind1991
commented
- Send path being scanned to ICAP server
- extend the self test to test for "new file" behavior
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
artonge
reviewed
May 21, 2024
| "PUT / HTTP/1.0", | ||
| "Host: 127.0.0.1" | ||
| "PUT $path HTTP/1.0", | ||
| "Host: nextcloud" |
There was a problem hiding this comment.
since whole request is fake anyway, I figured that it would be useful not mark the ICAP request as coming from Nextcloud for people who are looking at scanner reports
skjnldsv
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.